ATR Trailer

[ritusahu]

Hi my ea on ATR trailer is not placing any order. please sole the problem. find attachment.

[Enivid]

There's no point in attaching the EA's code (especially in a text file) here.

What version do you use - MT4 or MT5?
What settings do you use?
Does the smiling face appear in the top-right corner of the chart when you attach it?
Are there any errors in the Experts or Journal tabs of your terminal?

[ritusahu]

• I am using MT4(demo account). I am attaching this EA with EURUSD, M1 with
• ATR Period=10, Multiplier = 3.75,
• Yes the smiling face is coming on chart top right corner.
• No I am not getting any kind of error on both tab .
• When I am testing it using strategy tester it showing me the result, but its not trading.

Please find the attachment of ea with my previous thread.

[Enivid]

Did you make any other changes to the EA except for changing Multiplier type from int to double?

[ritusahu]

//+------------------------------------------------------------------+
//|                                                  ATR-Trailer.mq4 |
//|                                                    Andriy Moraru |
//|                                         [url]http://www.earnforex.com[/url] |
//|                                                                 2011 |
//+------------------------------------------------------------------+
#property copyright "www.EarnForex.com, 2011"
#property link      "http://www.earnforex.com"

// Plain trailing stop EA with ATR-based stop-loss.

#define LONG 1
#define SHORT 2

extern int ATR_Period = 10;
extern double ATR_Multiplier = 3.75;
extern int StartWith = 1; // 1 - Short, 2 - Long
extern int Slippage = 100;  // Tolerated slippage in pips
extern double Lots = 0.1;
    
extern int Magic = 123123123;

// Global variables
bool HaveLongPosition;
bool HaveShortPosition;
double StopLevel;
int LastPosition = 0;

int init()
{
   StopLevel = MarketInfo(Symbol(), MODE_STOPLEVEL) + MarketInfo(Symbol(), MODE_SPREAD);
   LastPosition = 3 - StartWith;
   return(0);
}

//+------------------------------------------------------------------+
//| Expert Every Tick Function                                       |
//+------------------------------------------------------------------+
int start()
{
    if (IsTradeAllowed() == false) return;
    
   // Getting the ATR values
   double ATR = iATR(NULL, 0, ATR_Period, 0);
   ATR *= ATR_Multiplier;

   if (ATR <= (MarketInfo(Symbol(), MODE_STOPLEVEL) + MarketInfo(Symbol(), MODE_SPREAD)) * Point) ATR = (MarketInfo(Symbol(), MODE_STOPLEVEL) + MarketInfo(Symbol(), MODE_SPREAD)) * Point;

    // Check what position is currently open
    GetPositionStates();
   
    // Adjust SL and TP of the current position
    if ((HaveLongPosition) || (HaveShortPosition)) AdjustSLTP(ATR);
   else
    {
    // Buy condition
    if (LastPosition == SHORT)
    {
            for (int i = 0; i < 10; i++)
            {
               RefreshRates();
                // Bid and Ask are swapped to preserve the probabilities and decrease/increase profit/loss size
             double SL = Bid - ATR;//NormalizeDouble(Bid - ATR, Digits);
             if (SL < StopLevel) SL = StopLevel;
                int result = OrderSend(Symbol(), OP_BUY, Lots, Ask, 100, SL,0, "ATR-Trader", Magic,0,Blue); 
                Sleep(1000);
            if (result == -1)
            {
               int e = GetLastError();
               Print(e);
            }
           
                else return(0);
            }
    }
    // Sell condition
    else if (LastPosition == LONG)
    {
            for (i = 0; i < 10; i++)
            {
               RefreshRates();
                // Bid and Ask are swapped to preserve the probabilities and decrease/increase profit/loss size
              SL = Ask + ATR;//NormalizeDouble(Ask + ATR, Digits);
              if (SL < StopLevel) SL = StopLevel;
                result = OrderSend(Symbol(), OP_SELL, Lots, Bid, 100, SL, 0, "ATR-Trader", Magic,0,Red); 
                Sleep(1000);
            if (result == -1)
            {
               e = GetLastError();
               Print(e);
            }
           
                else return(0);
            }
            
    }
     Print(MarketInfo(Symbol(), MODE_STOPLEVEL));
    }
    
    return(0);
}

//+------------------------------------------------------------------+
//| Check What Position is Currently Open                                       |
//+------------------------------------------------------------------+
void GetPositionStates()
{
   int total = OrdersTotal();
   for (int cnt = 0; cnt < total; cnt++)
   {
      if (OrderSelect(cnt, SELECT_BY_POS, MODE_TRADES) == false) continue;
      if (OrderMagicNumber() != Magic) continue;
      if (OrderSymbol() != Symbol()) continue;

      if (OrderType() == OP_BUY)
      {
            HaveLongPosition = true;
            HaveShortPosition = false;
        }
      else if (OrderType() == OP_SELL)
      {
            HaveLongPosition = false;
            HaveShortPosition = true;
        }
    if (HaveLongPosition) LastPosition = LONG;
    else if (HaveShortPosition) LastPosition = SHORT;
    return;
    }

   HaveLongPosition = false;
    HaveShortPosition = false;
}

//+------------------------------------------------------------------+
//| Adjust Stop-Loss and TakeProfit of the Open Position                    |
//+------------------------------------------------------------------+
void AdjustSLTP(double SLparam)
{
   int total = OrdersTotal();
   for (int cnt = 0; cnt < total; cnt++)
   {
      if (OrderSelect(cnt, SELECT_BY_POS, MODE_TRADES) == false) continue;
      if (OrderMagicNumber() != Magic) continue;
      if (OrderSymbol() != Symbol()) continue;

      if (OrderType() == OP_BUY)
        {
           RefreshRates();
            double SL =Bid - SLparam;
            if (SL < StopLevel) SL = StopLevel;
            if (SL > OrderStopLoss())
            {
                for (int i = 0; i < 10; i++)
                {
               bool result = OrderModify(OrderTicket(), OrderOpenPrice(), SL, 0, 0);
               if (result) return;
                }
            }
        }
      else if (OrderType() == OP_SELL)
        { 
           RefreshRates();
            SL = Ask + SLparam;
             if (SL < StopLevel) SL = StopLevel;
            if (SL < OrderStopLoss())
            {
                for (i = 0; i < 10; i++)
                {
               result = OrderModify(OrderTicket(), OrderOpenPrice(), SL, 0, 0);
               if (result) return;
                }
            }
        }
    }
}
//+------------------------------------------------------------------+

this is my complete EA ...
pleas check this

[ritusahu]

Its very Important EA for me. So please sir try to solve it out.. Waiting for your reply..

[Enivid]

Please use attachments to attach long files. If not attachment, then at least use code highlighting.

I've asked what changes have you done to the original EA (that can be found here)? I have no time for searching for your changes myself.

[ritusahu]

Changes made by me to the original EA are:

1. ATR period has changed from int to double .
2. double SL = Bid - ATR; instead of NormalizeDouble(Bid - ATR, Digits);//in Buy Condition.
3. SL = Ask + ATR; instead of NormalizeDouble(Ask + ATR, Digits);//in sell condition.
4. result = OrderSend(Symbol(), OP_SELL, Lots, Bid, 100, SL, 0, "ATR-Trader", Magic,0,Red);
instead of
result = OrderSend(Symbol(), OP_SELL, Lots, Bid, Slippage, SL, 0, "ATR-Trader", Magic);
5. In AdjustSLTP() function I have change
double SL = NormalizeDouble(Bid - SLparam, Digits);
to
double SL =Bid - SLparam;// for buy
SL = Ask + SLparam;// for sell
6. and lastly If condition used before OrderModify changes made is
if (SL < OrderStopLoss()) instead of if (SL < NormalizeDouble(OrderStopLoss(), Digits))

Thanks in advance.

[Enivid]

Heh... You forgot to mention two important things:

1. Your EA gives OrderSend Error 130.
2. Very important changes of yours:

StopLevel = MarketInfo(Symbol(), MODE_STOPLEVEL) + MarketInfo(Symbol(), MODE_SPREAD);

and

if (SL < StopLevel) SL = StopLevel;

The first piece of code sets StopLevel to something like 30 (at least with my broker), because you forget to multiply it with Point.

The second piece compares the valid stop-loss of about 1.3xxx with 30. Of course 30 is greater than the valid stop-loss and SL becomes = 30.

I think you know how to fix that now .

[nix]

hi guys, i new using atr trailer. cud anyone add in a TP at 60 pips in the ea, much appreciated , cheers