[MQL4 Coding Advise] Which is best for filtering order with symbol and Magic Number?

[shanmugapradeep]

Hello,

Which will be more effective, reliable and faster?

Code 1 :

void CloseOpenAndPendingTrades(int trade_close_magic)
  {
   for(int pos_0 = OrdersTotal() - 1; pos_0 >= 0; pos_0--)
     {
      OrderSelect(pos_0, SELECT_BY_POS, MODE_TRADES);
      if(OrderSymbol() != Symbol() || OrderMagicNumber() != trade_close_magic)
         continue;
 
      if(OrderType() > OP_SELL)
         OrderDelete(OrderTicket());
      else
        {
         if(OrderType() == OP_BUY)
            OrderClose(OrderTicket(), OrderLots(), Bid, 3, CLR_NONE);
         else
            OrderClose(OrderTicket(), OrderLots(), Ask, 3, CLR_NONE);
        }
     }
  }

Code 2 :

void CloseOpenAndPendingTrades(int trade_close_magic)
  {
   for(int pos_0 = OrdersTotal() - 1; pos_0 >= 0; pos_0--)
     {
      OrderSelect(pos_0, SELECT_BY_POS, MODE_TRADES);
      if(OrderSymbol() == Symbol() && OrderMagicNumber() == trade_close_magic)
         {
 
      if(OrderType() > OP_SELL)
         OrderDelete(OrderTicket());
      else
        {
         if(OrderType() == OP_BUY)
            OrderClose(OrderTicket(), OrderLots(), Bid, 3, CLR_NONE);
         else
            OrderClose(OrderTicket(), OrderLots(), Ask, 3, CLR_NONE);
        }
     }
  }
}

Using not Equal to (or) using Equal to?

 

[Enivid]

Shouldn't be much difference.

 

[Enivid]

I myself prefer the first variant because it offers better readability due to fewer curly brackets.

 

[shanmugapradeep]

I myself prefer the first variant because it offers better readability due to fewer curly brackets.

Thanks for suggestion.

Should i use BID/ASK :

if(OrderType() > OP_SELL)
         OrderDelete(OrderTicket());
      else
        {
         if(OrderType() == OP_BUY)
            OrderClose(OrderTicket(), OrderLots(), Bid, 3, CLR_NONE);
         else
            OrderClose(OrderTicket(), OrderLots(), Ask, 3, CLR_NONE);
        }

(OR) OrderClosePrice() :

if(OrderType() > OP_SELL)
         OrderDelete(OrderTicket());
      else
            OrderClose(OrderTicket(), OrderLots(), OrderClosePrice(), 3, CLR_NONE);

 

[Enivid]

Those are the same. With OrderClosePrice you get clearer code, but with Bid/Ask you are more explicit to the coder (including your future self) regarding which price is used to close which order.